Skip to content

Migrate archlinux importer - #935

Merged
pombredanne merged 16 commits into
mainfrom
597-migrate-archlinux
Oct 19, 2022
Merged

Migrate archlinux importer#935
pombredanne merged 16 commits into
mainfrom
597-migrate-archlinux

Conversation

@johnmhoran

@johnmhoran johnmhoran commented Oct 3, 2022

Copy link
Copy Markdown
Member

No description provided.

@johnmhoran
Begin work on parse_advisory() method, add initial tests #597
e762561 
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update univers version
a409570 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update univers version in setup.cfg #597
feb1663 
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Fix import sort #597
664af89 
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update parse_advisory() and tests #597
8d5ca76 
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update affected packages and test-advisory printing, clean up code #597
b003cfc 
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999
TG1999 reviewed Oct 10, 2022
View reviewed changes
Comment thread vulnerabilities/importers/archlinux.py Outdated
TG1999
TG1999 requested changes Oct 10, 2022
View reviewed changes

@TG1999 TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have few nits for your consideration

Comment thread vulnerabilities/importers/archlinux.py Outdated
Comment thread vulnerabilities/importers/archlinux.py Outdated
Comment thread vulnerabilities/tests/test_archlinux.py
Comment thread vulnerabilities/importers/archlinux.py
@TG1999 TG1999 mentioned this pull request Oct 10, 2022
Closed
@TG1999 TG1999 added this to the v31.0 milestone Oct 11, 2022
@johnmhoran
Refactor parse_advisory() #597
0d7b80a 
Reference: #935
Reference: #597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Merge branch 'main' into 597-migrate-archlinux
6be3186 
Merging latest 'main' into this archlinux importer branch.

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Begin work on patch-based tests #597
cce5f23 
Reference: #597
Reference: #935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Update importer mock test #597
136d758 
Reference: #935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Make final changes to archlinux testing #597
c5650b3 
Reference: #597
Reference: #935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Merge branch 'main' into 597-migrate-archlinux #597
38f501f 
Reference: #597
Reference: #935

Signed-off-by: John M. Horan johnmhoran@gmail.com
@TG1999
TG1999 marked this pull request as draft October 18, 2022 15:34
@johnmhoran

johnmhoran commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

Just tested my local copy of the Archlinux importer -- no errors:

(venv) Tue Oct 18, 2022 10:28 AM  /home/jmh/dev/nexb/vulnerablecode jmh (597-migrate-archlinux)
$ ./manage.py import vulnerabilities.importers.archlinux.ArchlinuxImporter
Importing data using vulnerabilities.importers.archlinux.ArchlinuxImporter
Successfully imported data using vulnerabilities.importers.archlinux.ArchlinuxImporter

(venv) Tue Oct 18, 2022 10:29 AM  /home/jmh/dev/nexb/vulnerablecode jmh (597-migrate-archlinux)
$

@johnmhoran
Adjust aliases according to archlinux data structure #597
0d71aa3 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
johnmhoran marked this pull request as ready for review October 18, 2022 18:30
pombredanne
pombredanne requested changes Oct 18, 2022
View reviewed changes

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM overall... One tiny nit picking for your consideration wrt. comments and avoiding code duplication.

Comment thread vulnerabilities/importers/archlinux.py
Comment thread vulnerabilities/utils.py Outdated
@pombredanne

pombredanne commented Oct 18, 2022

Copy link
Copy Markdown
Member

You also want to either rebase on main or merge the latest main.

@johnmhoran
Remove comment, replace alpine linux fetch_response() with new util…
ad3ebeb 
…s.py function #597

Reference: #597
Reference: #935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Merge branch 'main' into 597-migrate-archlinux and fix merge conflict
b6c59d6 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran
Delete test_data_source.py from collect_ignore list #597
1cadb72 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
pombredanne
pombredanne approved these changes Oct 19, 2022
View reviewed changes

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM... merging!

TG1999
TG1999 approved these changes Oct 19, 2022
View reviewed changes

@TG1999 TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@pombredanne
pombredanne merged commit 92eb01a into main Oct 19, 2022
@pombredanne
pombredanne deleted the 597-migrate-archlinux branch October 19, 2022 12:29
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Oct 19, 2022
@johnmhoran @TG1999
Refactor parse_advisory() aboutcode-org#597
2cafc45 
Reference: aboutcode-org#935
Reference: aboutcode-org#597

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Oct 19, 2022
@johnmhoran @TG1999
Begin work on patch-based tests aboutcode-org#597
c89c5a0 
Reference: aboutcode-org#597
Reference: aboutcode-org#935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Oct 19, 2022
@johnmhoran @TG1999
Update importer mock test aboutcode-org#597
9565c0e 
Reference: aboutcode-org#935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Oct 19, 2022
@johnmhoran @TG1999
Make final changes to archlinux testing aboutcode-org#597
317951c 
Reference: aboutcode-org#597
Reference: aboutcode-org#935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Oct 19, 2022
@johnmhoran @TG1999
Remove comment, replace alpine linux fetch_response() with new util…
97afb84 
…s.py function aboutcode-org#597

Reference: aboutcode-org#597
Reference: aboutcode-org#935

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne approved these changes
@TG1999 TG1999 TG1999 approved these changes

Assignees

No one assigned

Labels

import-improver-migration

Projects

None yet

Milestone

v31.0

Development

Successfully merging this pull request may close these issues.

3 participants

@johnmhoran @pombredanne @TG1999